Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix governance action provider metadata creation #1261

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix: fix governance action provider metadata creation #1261

merged 3 commits into from
Jun 12, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • Replace link with references to follow the CIP-100
  • Fix typo in reference map
  • Provide jsdoc for metadata methods
  • Update create GA doc

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski marked this pull request as draft June 12, 2024 12:00
vpaunovic
vpaunovic approved these changes Jun 12, 2024
View reviewed changes
Copy link

@vpaunovic vpaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MSzalowski MSzalowski marked this pull request as ready for review June 12, 2024 13:01
@MSzalowski MSzalowski merged commit 047fb22 into develop Jun 12, 2024
3 of 4 checks passed
@MSzalowski MSzalowski deleted the fix/fix-references-in-jsonld-creation branch June 12, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@teske00 teske00 teske00 approved these changes

@vpaunovic vpaunovic vpaunovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSzalowski @Sworzen1 @teske00 @vpaunovic