Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1234] Add reddis support for storing metadata validation results #1256

Merged
merged 3 commits into from
Jul 1, 2024
Merged

[#1234] Add reddis support for storing metadata validation results #1256

merged 3 commits into from
Jul 1, 2024

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Jun 11, 2024 •
edited
Loading

List of changes

Add

  • Reddis port, and host in backend config
  • Async process that fetches and processes metadata
  • querying Metadata returns result from Redis cache if available

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jankun4 jankun4 linked an issue Jun 11, 2024 that may be closed by this pull request
Provide workers to fetch and validate proposals and DRep #1234
Closed
@jankun4 jankun4 marked this pull request as ready for review June 17, 2024 09:19
@MSzalowski MSzalowski self-requested a review June 26, 2024 07:52
@MSzalowski
Copy link
Contributor

I've added redis configuration within this commit. Could you please provide an update within an application to support these changes? I've replaced direct properties with an object.

@spannercode spannercode mentioned this pull request Jun 26, 2024
Open
@MSzalowski MSzalowski force-pushed the 1234-provide-workers-to-fetch-and-validate-proposals-and-drep branch from e4522b0 to 45cc8aa Compare July 1, 2024 11:32
@MSzalowski MSzalowski merged commit 3db9567 into develop Jul 1, 2024
5 of 7 checks passed
@MSzalowski MSzalowski deleted the 1234-provide-workers-to-fetch-and-validate-proposals-and-drep branch July 1, 2024 11:44
MSzalowski added a commit that referenced this pull request Jul 2, 2024
@MSzalowski
Revert "Merge pull request #1256 from IntersectMBO/1234-provide-worke…
2ce6360 
…rs-to-fetch-and-validate-proposals-and-drep"

This reverts commit 3db9567, reversing
changes made to e582b5d.
MSzalowski added a commit that referenced this pull request Jul 2, 2024
@MSzalowski
Merge pull request #1454 from IntersectMBO/revert/1256
81f0387 
Revert "Merge pull request #1256 from IntersectMBO/1234-provide-workers-to-fetch-and-validate-proposals-and-drep"
@MSzalowski MSzalowski restored the 1234-provide-workers-to-fetch-and-validate-proposals-and-drep branch July 2, 2024 11:53
@pmbinapps pmbinapps mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide workers to fetch and validate proposals and DRep
2 participants
@jankun4 @MSzalowski