Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace hardcoded dRep registration amount with protocol params #1184

Merged
merged 2 commits into from
Jun 12, 2024
Merged

chore: Replace hardcoded dRep registration amount with protocol params #1184

merged 2 commits into from
Jun 12, 2024

Conversation

NabinKawan
Copy link
Contributor

List of changes

  • Replaced hardcoded value for dRep registration with protocol params

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from mesudip June 6, 2024 10:10
mesudip
mesudip requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update response type from QueryProtocolParams to ProtocolParams

mesudip
mesudip approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NabinKawan NabinKawan merged commit 5c5bb60 into develop Jun 12, 2024
@NabinKawan NabinKawan deleted the enhancement/transaction-amount branch June 12, 2024 08:17
@pmbinapps pmbinapps mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NabinKawan @mesudip