Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Discrepancy in DRep Vote Counts for Info Governance Actions Between dRep Registered and Disconnected States #1941

Closed
kneerose opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar

Comments

@kneerose
Copy link
Contributor

kneerose commented Sep 5, 2024

Area

Voting Pillar

Domain

preview.gov.tools

Which wallet were you using?

No response

Context

When viewing votes on Info governance actions, the system displays inaccurate vote counts. Specifically, the votes submitted by dReps appear as 0 ADA for registered dRep on show votes popup modal, regardless of actual votes submitted by dReps. But it shows actual vote count on disconnected state.

Steps to reproduce

  1. Connect to a wallet with a registered dRep.
  2. Navigate to any Info governance action.
  3. Click on "Show Votes."
  4. Observe the votes submitted by dReps.
  5. Disconnect the wallet.
  6. Observe the votes submitted by dReps.

Actual behavior

The votes submitted by dReps are shown as 0 ADA for registered dRep on Show votes popup modal, even though there are actual votes submitted by dReps.

For example, on the Info governance action at the following link: Info Governance Action

In the disconnected state:

image

On the connected state with dRep registered and after clicking on "Show Votes":

image

Expected behavior

The vote counts for any governance action should be consistent whether in the dRep connected state or the disconnected state.

Allure Report

https://cardanoapi.github.io/govtool-test-reports/govtool-frontend/98/#behaviors/1523ff4143db0faaf245e2252e8ca520/2d5432de94f0255a/

@kneerose kneerose added the 🐛 Bug Something isn't working label Sep 5, 2024
@bosko-m bosko-m removed their assignment Sep 5, 2024
@jdyczka jdyczka self-assigned this Sep 5, 2024
jdyczka added a commit that referenced this issue Sep 10, 2024
@Ryun1
Copy link
Member

Ryun1 commented Sep 11, 2024

Temp fix:

  • add other vote totals to the modal

Long term fix:

  • @m-i-k-e to refactor design for this page

jdyczka added a commit that referenced this issue Sep 12, 2024
…-modal

[#1941] show all kinds of votes in the modal showing vote numbers
@Ryun1 Ryun1 closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants