CAD-790: Tracers for node version. #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
added
WIP
denisshevchenko
force-pushed
the
cad-790-tracers-for-node-version
branch
from
89033d1 to
912435f
Compare
denisshevchenko
commented
Apr 3, 2020
denisshevchenko
force-pushed
the
cad-790-tracers-for-node-version
branch
from
912435f to
55a6dd0
Compare
denisshevchenko
force-pushed
the
cad-790-tracers-for-node-version
branch
from
55a6dd0 to
cf6bce4
Compare
CodiePP
approved these changes
Apr 3, 2020
CodiePP
added
byron
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
New tracers for node's release, version and commit. Currently, I'm creating the new service for a real-time view of metrics from the node. Since my service is a separate process, it receives these metrics via socket, using
TraceForwarder/TraceAcceptormechanism. So I need new tracers that will sendLogObjects with node's release (for example, "Shelley"), version (for example, "1.8.0") and Git commit. It will allow me to show this information in my service.Please not that currently it doesn't work: I don't see version info in the log!
This PR does not result in breaking changes to upstream dependencies.
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.