Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handshake and LocalHandshake Tracers #664

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Handshake and LocalHandshake Tracers #664

merged 2 commits into from
Mar 11, 2020

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Mar 11, 2020

Issue

#623

Checklist

  • [ x] This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • The work has sufficient tests and/or testing.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@karknu karknu force-pushed the karknu/up branch 2 times, most recently from 93fc7b7 to 7b6929d Compare March 11, 2020 09:48
@karknu karknu requested a review from coot March 11, 2020 10:08
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karknu
Copy link
Contributor Author

karknu commented Mar 11, 2020

bors r+

@Jimbo4350
Copy link
Contributor

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 11, 2020

Canceled

configuration/configuration-mainnet.yaml Outdated Show resolved Hide resolved
cardano-config/src/Cardano/Config/Types.hs Outdated Show resolved Hide resolved
configuration/log-configuration.yaml Outdated Show resolved Hide resolved
Add handshake and localhandshake tracer with config options.
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karknu
Copy link
Contributor Author

karknu commented Mar 11, 2020

bors +r

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 11, 2020

Did you mean "r+"?

@karknu
Copy link
Contributor Author

karknu commented Mar 11, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 11, 2020

@iohk-bors iohk-bors bot merged commit 5441d47 into master Mar 11, 2020
@iohk-bors iohk-bors bot deleted the karknu/up branch March 11, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants