Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-722 correct context name of internal metrics #659

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Mar 10, 2020

Issue

  • correct the context name of internal metrics that they are routed to the right backends and do not appear in the logs.

  • This PR does not result in breaking changes to upstream dependencies.

Checklist

  • This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • The work has sufficient tests and/or testing.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@CodiePP CodiePP added bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node. labels Mar 10, 2020
@CodiePP CodiePP added this to the S8 2020-03-12 milestone Mar 10, 2020
@CodiePP CodiePP requested review from deepfire and Jimbo4350 March 10, 2020 16:54
@CodiePP CodiePP self-assigned this Mar 10, 2020
@CodiePP CodiePP requested review from KtorZ and ksaric March 10, 2020 16:54
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 11, 2020

@iohk-bors iohk-bors bot merged commit 26a5410 into master Mar 11, 2020
@iohk-bors iohk-bors bot deleted the cad-722-context-name-internal-metrics branch March 11, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants