CAD-640: TraceForgedInvalidBlock trace: dump the why -- the InvalidBlockReason #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
approved these changes
Feb 27, 2020
deepfire
force-pushed
the
serge/thoroughly-trace-malforgery
branch
from
4e6d5a6 to
be50ce2
Compare
|
@intricate, @CodiePP and @dcoutts have already approved this PR in its previous incarnation -- this is only different in indentation, alignnment and your suggestion to use |
deepfire
force-pushed
the
serge/thoroughly-trace-malforgery
branch
3 times, most recently
from
d6f94f3 to
577c40f
Compare
deepfire
force-pushed
the
serge/thoroughly-trace-malforgery
branch
from
577c40f to
3b75ab4
Compare
deepfire
force-pushed
the
serge/thoroughly-trace-malforgery
branch
from
3b75ab4 to
14508cd
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submission of #585 -- which was irreversibly closed by Github due to its base having been merged.
ToObjectOrphanstocardano-config, because the instances are now needed in earlier code.defaultTextTransformerto reduce boilerplate inToObjectOrphansToObjectinstances to detail the error coming fromTraceForgedInvalidBlock.TraceForgeEventToObjectOrphans.hsIssue: #579
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.