Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed Protocols: new API #5956

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Typed Protocols: new API #5956

wants to merge 3 commits into from

Conversation

coot
Copy link
Contributor

@coot coot commented Aug 21, 2024

Description

  • Updated trace-forward library
  • WIP: Updated cardano-node - use new API of typed-protocols
  • Updated cardano-client-demo & benchmarking code

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

TODO:
  * consensusSanityCheckTracer
  * gddTracer
in `Cardano.Node.Tracing.Tracers` and `Cardano.Tracing.Tracers`
@coot coot added networking Issues and PRs related to networking typed-protocols labels Sep 27, 2024
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Issues and PRs related to networking Stale typed-protocols
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant