CAD-636: repair the JournalSK presentation #590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructuredLogging
traces asTextualRepresentation
in thecardano.node.text
namespaceJournalSK
usingmapScribes
Motivation
Currently
StructuredLogging
-based traces are only rendered intoJournalSK
via thePAYLOAD
field, with theMESSAGE
field being empty.Considerations:
Sample of JournalSK log output
Note that the log configuration is fairly indiscriminate, as per the example, so more events are included than what @disassembler originally requested:
..yields..:
Checklist
This PR contains all the work required to resolve the linked issue.
This PR results in breaking changes to upstream dependencies.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.