Add structured logging for TraceSendRecv TxSubmission objects #584
Conversation
intricate
force-pushed
the
intricate/527-2
branch
from
15c8c7c to
179ee61
Compare
| toObject _verb (MsgRequestTxIds _ _ _) = | ||
| mkObject | ||
| [ "kind" .= String "MsgRequestTxIds" | ||
| ] | ||
| toObject _verb (MsgReplyTxIds _) = | ||
| mkObject | ||
| [ "kind" .= String "MsgReplyTxIds" | ||
| ] | ||
| toObject _verb MsgDone = | ||
| mkObject | ||
| [ "kind" .= String "MsgDone" | ||
| ] |
There was a problem hiding this comment.
Is this going to be too noisy being logged at info?
There was a problem hiding this comment.
if these messages are useful to see in production then "Info" is right.
There was a problem hiding this comment.
Just a note: since MsgRequestTxs and MsgReplyTxs are the only useful constructors to log right now, I added a transformer in Cardano.Tracing.Tracers (see traceMsgRequestAndReplyTxs) to ensure that those are the only ones that are traced.
CodiePP
added
the
byron
| @@ -195,7 +195,7 @@ mkTracers traceOptions tracer = do | |||
| , consensusTracers | |||
| = mkConsensusTracers forgeTracers traceOptions | |||
| , protocolTracers | |||
| = mkProtocolsTracers traceOptions | |||
| = mkProtocolTracers traceOptions | |||
| toObject _verb (MsgRequestTxIds _ _ _) = | ||
| mkObject | ||
| [ "kind" .= String "MsgRequestTxIds" | ||
| ] | ||
| toObject _verb (MsgReplyTxIds _) = | ||
| mkObject | ||
| [ "kind" .= String "MsgReplyTxIds" | ||
| ] | ||
| toObject _verb MsgDone = | ||
| mkObject | ||
| [ "kind" .= String "MsgDone" | ||
| ] |
There was a problem hiding this comment.
if these messages are useful to see in production then "Info" is right.
intricate
force-pushed
the
intricate/527-2
branch
4 times, most recently
from
0aef763 to
a0ec6de
Compare
There was a problem hiding this comment.
I'm a little nervous about putting this into the low level protocol tracer. It is quite a high volume tracer. I'd be happier if we could do this in the tracer for the higher level "Inbound" and "Outbound" client & server implementations. This lets us be more precise about logging just the things we need, rather than every single message (and having to filter most of it out).
We already have a TraceTxSubmissionInbound and a TraceTxSubmissionOutbound.
So for our requirement:
We also need to trace at the default log level for the outbound side of tx submission:
- when a remote peer has requested a tx id, and we do send the tx to them, then we should log that the txid was requested and sent
I think we can do it just by extending the TraceTxSubmissionOutbound with the right thing and using it in the right place, and tracing that at default log level.
intricate
force-pushed
the
intricate/527-2
branch
from
a0ec6de to
1e029a0
Compare
|
Although this PR is no longer related to #527, it still adds structured logging for |
|
bors r+ |
584: Add structured logging for TraceSendRecv TxSubmission objects r=intricate a=intricate Co-authored-by: Luke Nadur <[email protected]>
Build succeeded |
1688: Trace transaction requests and replies in txSubmissionOutbound r=intricate a=intricate Related to IntersectMBO/cardano-node#527. More specifically, see IntersectMBO/cardano-node#584 (review). Co-authored-by: Luke Nadur <[email protected]>
624: Implement ToObject instance for TraceTxSubmissionOutbound r=intricate a=intricate Closes #527 See #584 (review) Co-authored-by: Luke Nadur <[email protected]>
No description provided.