Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EnabledP2PMode by default #5743

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Set EnabledP2PMode by default #5743

merged 1 commit into from
Apr 4, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Apr 3, 2024

Description

Set EnabledP2PMode by default, also added a mild warning when using the
legacy network stack.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@coot coot requested a review from a team as a code owner April 3, 2024 08:44
Also added a mild warning when using the legacy network stack.
@coot coot force-pushed the coot/p2p-default branch from 5fd0261 to 412195c Compare April 3, 2024 08:46
@coot coot requested review from Jimbo4350 and carbolymer April 3, 2024 13:20
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
@dnadales dnadales mentioned this pull request Apr 4, 2024
24 tasks
@disassembler disassembler removed this pull request from the merge queue due to a manual request Apr 4, 2024
@disassembler disassembler merged commit 750ea05 into master Apr 4, 2024
38 of 39 checks passed
@disassembler disassembler deleted the coot/p2p-default branch April 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants