cardano-testnet-test: Test CLI queries #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
smelc/update-hedgehog-extras-to-0.6.1.0
to
master
February 26, 2024 09:07
carbolymer
reviewed
Mar 4, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Queries.hs
Outdated
Show resolved
Hide resolved
carbolymer
reviewed
Mar 4, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Outdated
Show resolved
Hide resolved
carbolymer
reviewed
Mar 4, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Queries.hs
Show resolved
Hide resolved
carbolymer
reviewed
Mar 4, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Queries.hs
Show resolved
Hide resolved
carbolymer
approved these changes
Mar 4, 2024
smelc
force-pushed
the
smelc/test-cli-queries
branch
from
3e4dfee to
3f3dd9f
Compare
smelc
force-pushed
the
smelc/test-cli-queries
branch
8 times, most recently
from
54339e3 to
b17926c
Compare
smelc
changed the base branch from
master
to
mgalazyn/test/expose-parallel-testnet-flag
smelc
force-pushed
the
smelc/test-cli-queries
branch
2 times, most recently
from
9095577 to
1e75462
Compare
smelc
changed the base branch from
mgalazyn/test/expose-parallel-testnet-flag
to
master
smelc
force-pushed
the
smelc/test-cli-queries
branch
3 times, most recently
from
a15235b to
d29d993
Compare
smelc
force-pushed
the
smelc/test-cli-queries
branch
2 times, most recently
from
0d13a59 to
236b727
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
smelc
force-pushed
the
smelc/test-cli-queries
branch
from
a2120ac to
dfb527e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of fixing #5672
We test queries by calling them, and parsing the result when relevant. We don't want to go into much fine-grained tests for each query, because this would be better done in a test dedicated to each query. The point of this PR is to start covering all queries, to make sure we at least call them once, and hence detect breakage.
We test each query by using its stdout version and its version that writes to a file. We do that because some queries have different behaviors when writing to stdout and to a file (see IntersectMBO/cardano-cli#566 about this).
This PR doesn't cover all queries yet. I did only 3 so far, to get feedback on the design. If this design is accepted, let's merge this one; and I will do follow-up PRs to test other queries.
Checklist