Add CBOR pretty print and validation commands to cardano-cli
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
2 times, most recently
from
0789dfc to
df16374
Compare
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
5 times, most recently
from
70c17e2 to
d4333b6
Compare
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
from
d4333b6 to
305931a
Compare
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
from
305931a to
e8fc296
Compare
Jimbo4350
added
maintenance
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
3 times, most recently
from
d049daa to
2c81333
Compare
iohk-bors bot
added a commit
to IntersectMBO/cardano-prelude
that referenced
this pull request
Feb 18, 2020
97: Update `cborg` dependency to include pretty printing fix r=Jimbo4350 a=Jimbo4350 Required for IntersectMBO/cardano-node#545 Pretty printing fix: well-typed/cborg#223 Co-authored-by: Jordan Millar <[email protected]>
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
from
2c81333 to
675ffc2
Compare
dcoutts
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
This looks ok, but I think we should consider the following:
What we're doing in this patch is adding two intertwined features: validating the parsing of a byron block or tx, and pretty-printing a CBOR file. These things can be separate. We can parse any syntactically valid CBOR file completely generically (as a CBOR Term) without needing to know if it is a tx or a block or a CBOR representation of a cat.
So perhaps we should split this into a command to read and print any CBOR file, and separatly a command to validate a byron tx, or a byron block etc.
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
2 times, most recently
from
66b2e5b to
70a41c5
Compare
Jimbo4350
changed the title
cardano-clicardano-cli
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
from
70a41c5 to
4aa2a93
Compare
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
from
4aa2a93 to
4c8f8f3
Compare
|
bors r+ |
Merge conflict |
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
3 times, most recently
from
2f77d86 to
4bace2d
Compare
…a blocks, delegation certificates, txs and update proposals.
Jimbo4350
force-pushed
the
jordan/cbor-command-cli
branch
from
4bace2d to
40d6974
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add command to decode cbor #503
This PR adds two commands to
cardano-cli, apretty-print-cborcommand which pretty prints a given CBOR encoded file and avalidate-cborcommand which validates the CBOR encoding of a given file. Thevalidate-cborcommand currently supports Byron era blocks, delegation certificates, txs and update proposals.Required: Update
cborgdependency to include pretty printing fix cardano-prelude#97Required: Update
pprintto handle allTokenswell-typed/cborg#223checklist
This PR contains all the work required to resolve the linked issue.
This PR results in breaking changes to upstream dependencies.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.