Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-445 LiveView displays node id #534

Merged
merged 1 commit into from
Feb 4, 2020
Merged

CAD-445 LiveView displays node id #534

merged 1 commit into from
Feb 4, 2020

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Feb 3, 2020

correct the display of node id number in LiveView mode.
adapt to upstream type changes.

@CodiePP CodiePP added the byron Required for a Byron mainnet: replace the old core nodes with cardano-node. label Feb 3, 2020
@CodiePP CodiePP added this to the S6 2020-02-13 milestone Feb 3, 2020
deepfire
deepfire approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodiePP
CAD-445 LiveView displays node id
46fc9b5 
Signed-off-by: Alexander Diemand <[email protected]>
@CodiePP CodiePP force-pushed the cad-445-adapt-liveview branch from bc6ff43 to 46fc9b5 Compare February 4, 2020 12:47
@CodiePP
Copy link
Contributor Author

CodiePP commented Feb 4, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 4, 2020
@iohk-bors @CodiePP
Merge #534
2314183 
534: CAD-445 LiveView displays node id r=CodiePP a=CodiePP

correct the display of node id number in LiveView mode.
adapt to upstream type changes.

Co-authored-by: Alexander Diemand <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 4, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 46fc9b5 into master Feb 4, 2020
@iohk-bors iohk-bors bot deleted the cad-445-adapt-liveview branch February 4, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@oneEdoubleD oneEdoubleD Awaiting requested review from oneEdoubleD

Assignees
No one assigned
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node.
Projects
None yet
Milestone
S6 2020-02-13
Development

Successfully merging this pull request may close these issues.
2 participants
@CodiePP @deepfire