-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tip hash metrics #4915
Merged
Merged
Tip hash metrics #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/tip-hash-metrics
branch
8 times, most recently
from
February 24, 2023 14:09
ea6d92d
to
d7b25e6
Compare
Thanks 😁 |
newhoggy
force-pushed
the
newhoggy/tip-hash-metrics
branch
20 times, most recently
from
February 28, 2023 08:31
2df3570
to
87bb984
Compare
newhoggy
requested review from
JaredCorduan and
CarlosLopezDeLara
as code owners
February 28, 2023 08:31
newhoggy
force-pushed
the
newhoggy/tip-hash-metrics
branch
from
February 28, 2023 08:36
87bb984
to
05ec1d7
Compare
Jimbo4350
previously requested changes
Feb 28, 2023
newhoggy
force-pushed
the
newhoggy/tip-hash-metrics
branch
from
March 1, 2023 00:26
05ec1d7
to
57612b7
Compare
erikd
approved these changes
Mar 1, 2023
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 1, 2023
4912: Add slotsInEpoch and slotsToEpochEnd to query tip command r=newhoggy a=newhoggy Example output: ``` CARDANO_NODE_SOCKET_PATH=example/node-pool1/node.sock cardano-cli query tip --testnet-magic 42 { "block": 768, "epoch": 33, "era": "Alonzo", "hash": "4ca7fd3a9827e74f98e779a8ae333dc6fa3b69832cb11fdbab7af215eb68b1ee", "slot": 16814, "slotsInEpoch": 314, "slotsToEpochEnd": 186, "syncProgress": "100.00" } ``` Resolves #3878 4915: Tip hash metrics r=newhoggy a=newhoggy Salvaging this PR #2006 Related to #801 4922: Deploy Haddock for merge to master only r=newhoggy a=newhoggy To merge changes from this PR #3012 Co-authored-by: John Ky <[email protected]> Co-authored-by: Luke Nadur <[email protected]> Co-authored-by: James Browning <[email protected]>
This PR was included in a batch that timed out, it will be automatically retried |
Jimbo4350
previously requested changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You should be able to squash your commit into the first one without issue
iohk-bors bot
added a commit
that referenced
this pull request
Mar 1, 2023
4915: Tip hash metrics r=newhoggy a=newhoggy Salvaging this PR #2006 Related to #801 4918: Fix key non extended key for StakeExtendedVerificationKeyShelley_ed25519_bip32 envelope r=newhoggy a=newhoggy * Fix key non extended key for `StakeExtendedVerificationKeyShelley_ed25519_bip32` envelope * Add ability to generate golden files from test using `CREATE_GOLDEN_FILES=1` * New `diffFileVsGoldenFile` function Resolves #4914 4922: Deploy Haddock for merge to master only r=newhoggy a=newhoggy To merge changes from this PR #3012 Co-authored-by: Luke Nadur <[email protected]> Co-authored-by: John Ky <[email protected]> Co-authored-by: James Browning <[email protected]>
bors r- |
Canceled. |
newhoggy
force-pushed
the
newhoggy/tip-hash-metrics
branch
from
March 2, 2023 17:11
57612b7
to
ca6a1f3
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salvaging this PR #2006
Related to #801