Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-438 replacement Prometheus interface #491

Merged
merged 1 commit into from
Jan 23, 2020
Merged

CAD-438 replacement Prometheus interface #491

merged 1 commit into from
Jan 23, 2020

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Jan 22, 2020

update iohk-monitoring: replacement for the Prometheus interface

@CodiePP CodiePP force-pushed the cad-438-replacement-prometheus-interface branch from dfc0783 to d10aa0b Compare January 22, 2020 22:18
@CodiePP CodiePP requested a review from johnalotoski January 22, 2020 22:18
@CodiePP CodiePP added this to the S5 2020-01-30 milestone Jan 22, 2020
@CodiePP CodiePP added bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node. labels Jan 22, 2020
@CodiePP CodiePP marked this pull request as ready for review January 22, 2020 22:37
@CodiePP CodiePP requested a review from ksaric January 22, 2020 22:37
ksaric
ksaric approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CodiePP
Copy link
Contributor Author

CodiePP commented Jan 23, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 23, 2020
@iohk-bors @CodiePP
Merge #491
180c909 
491: CAD-438 replacement Prometheus interface r=CodiePP a=CodiePP

update iohk-monitoring: replacement for the Prometheus interface

Co-authored-by: Alexander Diemand <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 23, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit d10aa0b into master Jan 23, 2020
@iohk-bors iohk-bors bot deleted the cad-438-replacement-prometheus-interface branch January 23, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksaric ksaric ksaric approved these changes

@johnalotoski johnalotoski Awaiting requested review from johnalotoski

Assignees
No one assigned
Labels
bug Something isn't working byron Required for a Byron mainnet: replace the old core nodes with cardano-node.
Projects
None yet
Milestone
S5 2020-01-30
Development

Successfully merging this pull request may close these issues.
2 participants
@CodiePP @ksaric