Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out duplicate collateral inputs in transaction build and build-raw #4749

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

Jimbo4350
Copy link
Contributor

Resolves #4744

@nielstron
Copy link
Contributor

nielstron commented Jan 5, 2023

This is a small code change so I don't mind but for the future:

The way you re-used my commit kicks me out of the git commit authors (I saw you wrote it in the commit message but its not registered by git itself). If someone has contributed a large code change they might want this to show in the project statistics or on their profile. For that, you can copy the branch of that person (including their authored commits) and then modify in your own repository (even merging commits if thats what you are aiming for). The benefit is that the original author stays co-contributor, recognized by git. Something like the following should do the trick (in this particular case):

git remote add nielstron https://github.com/nielstron/cardano-node
git fetch nielstron
git checkout fix/filter-collateral-inputs
# < do your modifications of the branch >
git push -u origin fix/filter-collateral-inputs # prevents access errors by pushing into own/controlled repo

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Jan 5, 2023

This is a small code change so I don't mind but for the future:

The way you re-used my commit kicks me out of the git commit authors (I saw you wrote it in the commit message but its not registered by git itself). If someone has contributed a large code change they might want this to show in the project statistics or on their profile. For that, you can copy the branch of that person (including their authored commits) and then modify in your own repository (even merging commits if thats what you are aiming for). The benefit is that the original author stays co-contributor, recognized by git. Something like the following should do the trick (in this particular case):

git remote add nielstron https://github.com/nielstron/cardano-node
git fetch nielstron
git checkout fix/filter-collateral-inputs
# < do your modifications of the branch >
git push -u origin fix/filter-collateral-inputs # prevents access errors by pushing into own/controlled repo

Thanks for this, I will follow this procedure for this PR and future contributions.

@Jimbo4350 Jimbo4350 force-pushed the jordan/duplicate-collateral-inputs branch from 08a6cdb to 14369b4 Compare January 5, 2023 14:47
@Jimbo4350 Jimbo4350 merged commit c2808b9 into master Jan 11, 2023
@iohk-bors iohk-bors bot deleted the jordan/duplicate-collateral-inputs branch January 11, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Cardano-cli computes wrong collateral return output for multiple occurrences of collateral inputs
2 participants