-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix and test for foldBlocks
#4679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyeinsky
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
November 29, 2022 18:00
eyeinsky
added a commit
that referenced
this pull request
Nov 30, 2022
- Add hashes of genesis.json to node configuration - Add test for running foldBlocks on testnet
eyeinsky
force-pushed
the
ml/foldblocks-test
branch
from
November 30, 2022 13:37
d19a544
to
201789d
Compare
9 tasks
JaredCorduan
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding tests!
Jimbo4350
approved these changes
Dec 5, 2022
eyeinsky
added a commit
that referenced
this pull request
Dec 8, 2022
- Add hashes of genesis.json to node configuration - Add test for running foldBlocks on testnet
eyeinsky
force-pushed
the
ml/foldblocks-test
branch
from
December 8, 2022 12:49
201789d
to
831fdf1
Compare
eyeinsky
added a commit
that referenced
this pull request
Dec 9, 2022
- Add hashes of genesis.json to node configuration - Add test for running foldBlocks on testnet
eyeinsky
force-pushed
the
ml/foldblocks-test
branch
from
December 9, 2022 10:05
831fdf1
to
1b868cc
Compare
eyeinsky
added a commit
that referenced
this pull request
Dec 14, 2022
- Add hashes of genesis.json to node configuration - Add test for running foldBlocks on testnet
eyeinsky
force-pushed
the
ml/foldblocks-test
branch
from
December 14, 2022 10:07
1b868cc
to
ec0c5ab
Compare
- Add hashes of genesis.json to node configuration - Add test for running foldBlocks on testnet
eyeinsky
force-pushed
the
ml/foldblocks-test
branch
from
December 14, 2022 11:42
ec0c5ab
to
509c125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR (old here) based off from a branch in this repository. Original issue here: #4624.
lock