Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench nomad #4606

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Bench nomad #4606

merged 6 commits into from
Nov 25, 2022

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Nov 3, 2022 •
edited
Loading

  • New workbench backend based on nomad/podman
  • Add multi-backend support using make BACKEND=nomad shell
  • Using nix2container to build the OCI images for performance issues

@fmaste fmaste force-pushed the bench-nomad branch 2 times, most recently from 2e392b8 to 6fd229d Compare November 3, 2022 20:21
@deepfire deepfire force-pushed the bench-master branch 7 times, most recently from cea32c4 to 046751a Compare November 7, 2022 12:26
@deepfire deepfire force-pushed the bench-master branch 12 times, most recently from 2ef959b to 3924998 Compare November 11, 2022 12:38
@deepfire deepfire force-pushed the bench-master branch 3 times, most recently from 6034f96 to 0fbf71b Compare November 14, 2022 15:32
@deepfire deepfire force-pushed the bench-master branch 6 times, most recently from 7bcc8d7 to 5245077 Compare November 21, 2022 21:19
@deepfire deepfire marked this pull request as ready for review November 22, 2022 11:51
@deepfire deepfire requested review from a team, deepfire and mgmeier as code owners November 22, 2022 11:51
deepfire
deepfire approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot @fmaste, this is fantastic work!

@deepfire
Copy link
Contributor

This needs:

  1. a description
  2. history cleanup for the latter commits

@fmaste fmaste changed the base branch from bench-master to master November 22, 2022 11:57
@fmaste fmaste force-pushed the bench-nomad branch 2 times, most recently from f7495d6 to fef9878 Compare November 23, 2022 12:31
@fmaste
Copy link
Contributor Author

fmaste commented Nov 25, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 25, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 84fa2e2 into master Nov 25, 2022
@iohk-bors iohk-bors bot deleted the bench-nomad branch November 25, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@mgmeier mgmeier Awaiting requested review from mgmeier

@jutaro jutaro Awaiting requested review from jutaro

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmaste @deepfire