-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error message for incorrectly witnessed collateral inputs #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction build command to construct transactions from prior eras
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan and
LudvikGalois
as code owners
September 27, 2022 11:28
Jimbo4350
force-pushed
the
jordan/4479-bug
branch
from
September 27, 2022 11:28
de3f8bf
to
d100008
Compare
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Sep 27, 2022
mkoura
approved these changes
Sep 27, 2022
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 28, 2022
4484: Update error message for incorrectly witnessed collateral inputs r=Jimbo4350 a=Jimbo4350 Resolves: #4479 Co-authored-by: Jordan Millar <[email protected]>
Timed out. |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 28, 2022
4466: Added changelogs for releases between 1.34.0 and 1.35.3 r=Jimbo4350 a=LaurenceIO Updated api, cli, node, and submit-api changelogs on master with changes in 1.34.0, 1.34.1, 1.35.0, 1.35.1, 1.35.2, and 1.35.3 releases. Thanks to `@ltouro` for highlighting a typo. 4484: Update error message for incorrectly witnessed collateral inputs r=Jimbo4350 a=Jimbo4350 Resolves: #4479 4486: tx-generator: Use distinct keys/addresses for benchmarking phases r=MarcFontaine a=MarcFontaine This is useful for debugging the tx-generator. Hard coded addresses: `addr_test1vzj7zv9msmdasvy5nc9jhnn2gqvrvu33v5rlg332zdfrkugklxkau` : outputs of the splitting phase (value not Plutus). `addr_test1vz4qz2ayucp7xvnthrx93uhha7e04gvxttpnuq4e6mx2n5gzfw23z` : final outputs of the benchmarking phase. Co-authored-by: LaurenceIO <[email protected]> Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: MarcFontaine <[email protected]>
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Jimbo4350
added a commit
that referenced
this pull request
Sep 29, 2022
Update error message for incorrectly witnessed collateral inputs
disassembler
pushed a commit
that referenced
this pull request
Sep 29, 2022
Update error message for incorrectly witnessed collateral inputs
newhoggy
pushed a commit
that referenced
this pull request
Sep 29, 2022
Update error message for incorrectly witnessed collateral inputs
Jimbo4350
added a commit
that referenced
this pull request
Oct 5, 2022
Update error message for incorrectly witnessed collateral inputs
Jimbo4350
added a commit
that referenced
this pull request
Oct 5, 2022
Update error message for incorrectly witnessed collateral inputs
disassembler
pushed a commit
that referenced
this pull request
Oct 25, 2022
Update error message for incorrectly witnessed collateral inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4479