Infer protocol params in transaction build #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvikGalois
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
LudvikGalois
force-pushed
the
ludvikgalois/infer-pparams-in-build
branch
3 times, most recently
from
f668ced
to
b077243
Compare
LudvikGalois
changed the title
LudvikGalois
force-pushed
the
ludvikgalois/infer-pparams-in-build
branch
from
b077243
to
a9bac5c
Compare
LudvikGalois
force-pushed
the
ludvikgalois/infer-pparams-in-build
branch
from
a9bac5c
to
7f70c73
Compare
Jimbo4350
approved these changes
Sep 27, 2022
LudvikGalois
force-pushed
the
ludvikgalois/infer-pparams-in-build
branch
from
7f70c73
to
933ba81
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
4431: Infer protocol params in transaction build r=LudvikGalois a=LudvikGalois We now ignore the `--protocol-params-file` in the `transaction build` command. Instead we fetch it from the node directly. If the user still supplies it, we display a warning, but otherwise continue. Fixes #4058 Co-authored-by: Robert 'Probie' Offner <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Merge conflict. |
Jimbo4350
force-pushed
the
ludvikgalois/infer-pparams-in-build
branch
from
933ba81
to
133ac29
Compare
Jimbo4350
force-pushed
the
ludvikgalois/infer-pparams-in-build
branch
from
133ac29
to
a18b1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now ignore the
--protocol-params-filein thetransaction buildcommand. Instead wefetch it from the node directly. If the user still supplies it, we display a warning, but otherwise
continue.
Fixes #4058