-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump babbage to report it supports 7.1 in block header #4211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
4211: bump babbage to report it supports 7.1 in block header r=disassembler a=disassembler Bumping to 7.1 to identify nodes that have updated to 1.35.2 Co-authored-by: Samuel Leathers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've changed the protocol version that the node will declare it understands when it's in the Babbage era, but you've not change the protocol version that the node will declare it understands when it's in the Alonzo era.
In the Alonzo era, nodes now need to declare they understand 7.1, not 7.0. They will also declare the same for now when they move into the Babbage era, but that's just for consistency/sanity. It's what they declare now, before the Babbage HF that's really important.
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
e0df949
to
000a10f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
Build succeeded: |
for posterity, let me mention that we are not actually moving to protocol version |
Bumping to 7.1 to identify nodes that have updated to 1.35.2