Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump babbage to report it supports 7.1 in block header #4211

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

disassembler
Copy link
Contributor

@disassembler disassembler commented Jul 21, 2022

Bumping to 7.1 to identify nodes that have updated to 1.35.2

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disassembler
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 21, 2022
4211: bump babbage to report it supports 7.1 in block header r=disassembler a=disassembler

Bumping to 7.1 to identify nodes that have updated to 1.35.2

Co-authored-by: Samuel Leathers <[email protected]>
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've changed the protocol version that the node will declare it understands when it's in the Babbage era, but you've not change the protocol version that the node will declare it understands when it's in the Alonzo era.

In the Alonzo era, nodes now need to declare they understand 7.1, not 7.0. They will also declare the same for now when they move into the Babbage era, but that's just for consistency/sanity. It's what they declare now, before the Babbage HF that's really important.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 21, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disassembler
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 21, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 6b79028 into master Jul 21, 2022
@iohk-bors iohk-bors bot deleted the babbage-7.1 branch July 21, 2022 17:41
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Jul 23, 2022
3 tasks
@JaredCorduan
Copy link
Contributor

for posterity, let me mention that we are not actually moving to protocol version 7.1. This is a hack, but without the hack we are blind to various versions of the node that are declaring "I'm ready for version 7", but in fact have different behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants