Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build and build-raw commands to accept simple reference minting scripts #4087

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Jimbo4350
Copy link
Contributor

Closes: #4086

@catch-21
Copy link
Contributor

catch-21 commented Jun 23, 2022

For the following flags, consider rewording their description because:

  1. it suggests the reference input doesn't need a reference script, but it definitely must have one to work.
  2. It says "plutus" for all of them but some are simple scripts

--spending-tx-in-reference --simple-script-tx-in-reference --simple-minting-script-tx-in-reference --mint-tx-in-reference --certificate-tx-in-reference --withdrawal-tx-in-reference

TxId#TxIx - Specify a reference input. The reference
input may or may not have a plutus reference script
attached.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jimbo4350 Jimbo4350 force-pushed the jordan/simple-reference-minting-scripts branch from c1a82c0 to 967ae39 Compare June 24, 2022 16:13
@Jimbo4350 Jimbo4350 force-pushed the jordan/simple-reference-minting-scripts branch from 967ae39 to 64f88c8 Compare June 24, 2022 16:31
@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 24, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit d7cd53e into master Jun 24, 2022
@iohk-bors iohk-bors bot deleted the jordan/simple-reference-minting-scripts branch June 24, 2022 17:09
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Aug 2, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Is not possible to mint using a reference simple script with the cli
3 participants