Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-tracer: init RTView #3852

Merged
merged 2 commits into from
May 27, 2022
Merged

Conversation

denisshevchenko
Copy link
Contributor

This is pre-MVP for RTView.

@denisshevchenko denisshevchenko self-assigned this May 10, 2022
@denisshevchenko denisshevchenko added the RTView The service for monitoring over Cardano nodes label May 10, 2022
@denisshevchenko denisshevchenko linked an issue May 10, 2022 that may be closed by this pull request
@denisshevchenko denisshevchenko force-pushed the cad-3845-rtview-in-cardano-tracer branch 3 times, most recently from 8f34813 to ee7dacd Compare May 17, 2022 12:20
@denisshevchenko denisshevchenko force-pushed the cad-3845-rtview-in-cardano-tracer branch from c6cf7ea to 217d70b Compare May 20, 2022 05:47
@denisshevchenko denisshevchenko marked this pull request as ready for review May 20, 2022 06:01
@denisshevchenko denisshevchenko force-pushed the cad-3845-rtview-in-cardano-tracer branch from 217d70b to 9c97b64 Compare May 20, 2022 06:09
@denisshevchenko denisshevchenko force-pushed the cad-3845-rtview-in-cardano-tracer branch 4 times, most recently from 0150080 to ecebefe Compare May 23, 2022 13:11
@deepfire deepfire force-pushed the cad-3845-rtview-in-cardano-tracer branch from 86de846 to ab3da99 Compare May 23, 2022 16:00
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you Denis!

@denisshevchenko
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 23, 2022
3852: cardano-tracer: init RTView r=denisshevchenko a=denisshevchenko

This is pre-MVP for RTView.

3882: Fix datum in tx and ref scripts r=Jimbo4350 a=ch1bo

(Couldn't reopen #3881, so created this one)

:snowflake: Add a roundtrip property `TxBodyContent -> TxBody -> TxBodyContent`

This helped in fixing the :bug: and uncover the two additional gaps in the code. I'm not 100% happy with the current implementation of the property though! I needed to accept two exceptions to the general `===`:

  1. `SimpleScriptV1` reference scripts may become `SimpleScriptV2`
  2. A `TxOutDatumHash` + a matching `ScriptData` may become a `TxOutDatumTx`

:snowflake: Resolve datum hash + matching datum in transaction to `TxOutDatumInTx`, fixes #3866 

❄️ Add missing script languages to `scriptLanguageSupportedInEra` for `BabbageEra`

❄️ Allow scripts in any language as refeference scripts

Co-authored-by: Denis Shevchenko <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 23, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request May 23, 2022
3852: cardano-tracer: init RTView r=deepfire a=denisshevchenko

This is pre-MVP for RTView.

3880: Old peers tracing was erroneously called in new tracing r=deepfire a=jutaro

/nix/store/qaplqccmisqy8n7ai65nssafzkxyyc7p-cabal-install-exe-cabal-3.6.2.0/bin/cabal --project-file=/home/deepfire/cardano-node/.nix-shell-cabal.project run exe:cardano-node -- +RTS -sghc-rts-report.txt -RTS run --config config.json --database-path run/current/node-0/db-testnet --topology topology.json --host-addr 127.0.0.1 --port 30000 --socket-path node.socket +RTS -N2 -I0 -A16m -qg -qb --disable-delayed-os-memory-return -RTS
cardano-node: ExceptionInLinkedThread (ThreadId 11) The name ""peersFromNodeKernel"" is already taken by a metric.
CallStack (from HasCallStack):
  error, called at ./System/Metrics.hs:214:5 in ekg-core-0.1.1.7-FjoslY1tzknIAl90c73kOZ:System.Metrics

3882: Fix datum in tx and ref scripts r=Jimbo4350 a=ch1bo

(Couldn't reopen #3881, so created this one)

:snowflake: Add a roundtrip property `TxBodyContent -> TxBody -> TxBodyContent`

This helped in fixing the :bug: and uncover the two additional gaps in the code. I'm not 100% happy with the current implementation of the property though! I needed to accept two exceptions to the general `===`:

  1. `SimpleScriptV1` reference scripts may become `SimpleScriptV2`
  2. A `TxOutDatumHash` + a matching `ScriptData` may become a `TxOutDatumTx`

:snowflake: Resolve datum hash + matching datum in transaction to `TxOutDatumInTx`, fixes #3866 

❄️ Add missing script languages to `scriptLanguageSupportedInEra` for `BabbageEra`

❄️ Allow scripts in any language as refeference scripts

Co-authored-by: Denis Shevchenko <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
Co-authored-by: Yupanqui <[email protected]>
Co-authored-by: Sebastian Nagel <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 24, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@denisshevchenko
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 24, 2022
3852: cardano-tracer: init RTView r=denisshevchenko a=denisshevchenko

This is pre-MVP for RTView.

3898: Standardised payment key directory structure r=newhoggy a=newhoggy

Now payment keys live in `example/utxo-keys` for both the alonzo and babbage testnets.

Co-authored-by: Denis Shevchenko <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
Co-authored-by: John Ky <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 24, 2022

This PR was included in a batch that timed out, it will be automatically retried

@deepfire deepfire force-pushed the cad-3845-rtview-in-cardano-tracer branch from ab3da99 to 8d4b5b1 Compare May 24, 2022 19:24
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 24, 2022

Canceled.

@denisshevchenko
Copy link
Contributor Author

bors r+

@denisshevchenko
Copy link
Contributor Author

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 25, 2022

Canceled.

@deepfire deepfire force-pushed the cad-3845-rtview-in-cardano-tracer branch from 8d4b5b1 to 756111c Compare May 26, 2022 14:03
@deepfire
Copy link
Contributor

bors r_

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request May 26, 2022
3852: cardano-tracer: init RTView r=deepfire a=denisshevchenko

This is pre-MVP for RTView.

Co-authored-by: Denis Shevchenko <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2022

Timed out.

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request May 26, 2022
3852: cardano-tracer: init RTView r=deepfire a=denisshevchenko

This is pre-MVP for RTView.

Co-authored-by: Denis Shevchenko <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 27, 2022

Build failed:

@deepfire deepfire force-pushed the cad-3845-rtview-in-cardano-tracer branch from 756111c to 257397c Compare May 27, 2022 12:27
@deepfire deepfire force-pushed the cad-3845-rtview-in-cardano-tracer branch from 257397c to 443a41e Compare May 27, 2022 12:29
@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 27, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 0f025a0 into master May 27, 2022
@iohk-bors iohk-bors bot deleted the cad-3845-rtview-in-cardano-tracer branch May 27, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RTView The service for monitoring over Cardano nodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the UI for cardano-tracer based RTView
3 participants