Propagate protocol in block type #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/dep-bump-protocol-in-block
branch
3 times, most recently
from
99cffa2
to
c5099a5
Compare
Jimbo4350
force-pushed
the
jordan/dep-bump-protocol-in-block
branch
8 times, most recently
from
286402b
to
98892cb
Compare
Jimbo4350
requested review from
deepfire,
denisshevchenko,
jutaro,
coot,
MarcFontaine,
cleverca22,
DavidEichmann,
dcoutts,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
newhoggy
force-pushed
the
jordan/dep-bump-protocol-in-block
branch
2 times, most recently
from
d0e7f46
to
f555430
Compare
newhoggy
reviewed
May 4, 2022
| Praos.babbageProtVer = | ||
| if npcTestEnableDevelopmentHardForkEras | ||
| then ProtVer 7 0 -- Advertise we can support Babbage | ||
| else ProtVer 6 0, -- Otherwise we only advertise we know about Mary,= |
There was a problem hiding this comment.
Is the trailing ,= intended?
throughout cardano-api. Note this leaves the leadership-schedule, kes-info and protocol-state query commands temporarily broken.
Update readFileTx and acceptTxCDDLSerialisation functions for Babbage Disable the kes-period-info command test temporarily
Jimbo4350
force-pushed
the
jordan/dep-bump-protocol-in-block
branch
from
b6a6851
to
55d1ec3
Compare
nfrisby
force-pushed
the
jordan/dep-bump-protocol-in-block
branch
from
6036e3c
to
b4308ef
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
May 20, 2022
3818: Propagate protocol in block type r=Jimbo4350 a=Jimbo4350 This PR: - Propagates updated ShelleyBlock type (which is now also parameterized over the protocol) - Re-enables the TestEnableDevelopmentHardForkEras flag so we can hardfork to Babbage without advertising we know about the Babbage era Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Nicolas Frisby <[email protected]> Co-authored-by: Alexander Esgen <[email protected]>
|
Timed out. |
deepfire
pushed a commit
that referenced
this pull request
May 20, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
May 21, 2022
3818: Propagate protocol in block type r=disassembler a=Jimbo4350 This PR: - Propagates updated ShelleyBlock type (which is now also parameterized over the protocol) - Re-enables the TestEnableDevelopmentHardForkEras flag so we can hardfork to Babbage without advertising we know about the Babbage era Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: Nicolas Frisby <[email protected]> Co-authored-by: Alexander Esgen <[email protected]>
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
deepfire
pushed a commit
that referenced
this pull request
May 22, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
deepfire
pushed a commit
that referenced
this pull request
May 22, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
deepfire
pushed a commit
that referenced
this pull request
May 23, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
MarcFontaine
added a commit
that referenced
this pull request
May 25, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
Closed
8 tasks
deepfire
pushed a commit
that referenced
this pull request
May 26, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
deepfire
pushed a commit
that referenced
this pull request
May 27, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
deepfire
pushed a commit
that referenced
this pull request
May 27, 2022
sized Metadate : tests for Alonzo & Babbage rebase on #3818 and reuse code from Cardano.Api.InMode fixes in SubmissionClient workbench: add babbage era
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: