Expose the tx mempool monitoring mini protocol in cardano-api #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
DavidEichmann,
dcoutts,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
Jimbo4350
force-pushed
the
jordan/wireup-tx-mempool-monitoring
branch
2 times, most recently
from
3e0859d
to
93fd249
Compare
newhoggy
reviewed
Mar 15, 2022
Jimbo4350
force-pushed
the
jordan/wireup-tx-mempool-monitoring
branch
2 times, most recently
from
b392380
to
4110200
Compare
Implement TxIdInMode This sets the stage to expose a user facing function to utilize the local tx monitoring mini protocol
…nality to utilize the local tx monitoring protocol which allows users to: Check if a transaction exists in the mempool Request the next tx in the mempool Request the current size and capacity of the mempool Note: This is not exposed via cardano-cli as yet
Jimbo4350
force-pushed
the
jordan/wireup-tx-mempool-monitoring
branch
from
4110200
to
ac8f3b5
Compare
newhoggy
reviewed
Mar 31, 2022
| -- | The mempool is modeled as an ordered list of transactions and thus, can | ||
| -- be traversed linearly. 'LocalTxMonitoringSendNextTx' requests the next transaction from the | ||
| -- current list. This must be a transaction that was not previously sent to | ||
| -- the client for this particular snapshot. |
There was a problem hiding this comment.
Is there state associated with the connection that tracks where the current transaction in the list is?
There was a problem hiding this comment.
There are only 3 things you can get:
data ServerStBusy (kind :: StBusyKind) txid tx slot m a where
SendMsgReplyNextTx
:: Maybe tx
-> ServerStAcquired txid tx slot m a
-> ServerStBusy NextTx txid tx slot m a
SendMsgReplyHasTx
:: Bool
-> ServerStAcquired txid tx slot m a
-> ServerStBusy HasTx txid tx slot m a
SendMsgReplyGetSizes
:: MempoolSizeAndCapacity
-> ServerStAcquired txid tx slot m a
-> ServerStBusy GetSizes txid tx slot
The next tx, if a tx exists or the mempool size.
newhoggy
reviewed
Mar 31, 2022
| @@ -6,12 +6,17 @@ | |||
| -- | Transactions in the context of a consensus mode, and other types used in | |||
| -- the transaction submission protocol. | |||
| -- | |||
| module Cardano.Api.TxInMode ( | |||
| module Cardano.Api.InMode ( | |||
There was a problem hiding this comment.
What's the motivation for the module rename?
Maybe the comment for the module needs adjustment too?
There was a problem hiding this comment.
So we now have TxInMode and TxIdInMode. I figured it would make sense to drop the Tx because of this.
newhoggy
approved these changes
Apr 5, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3698