Simpler topology #318
Closed
Simpler topology #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
reviewed
Nov 20, 2019
deepfire
force-pushed
the
serge/simpler-topology
branch
from
49c7b64 to
c75fbb1
Compare
deepfire
force-pushed
the
serge/simpler-topology
branch
from
c75fbb1 to
7966bc1
Compare
deepfire
force-pushed
the
serge/simpler-topology
branch
from
7966bc1 to
a2c9b2e
Compare
|
Heavy conflicts with #320 .. |
This was referenced Nov 25, 2019
Merged
iohk-bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
330: Transaction generator: specify target nodes without topology. r=CodiePP a=denisshevchenko #329 Since #318 is going to eliminate `TopologyInfo` type, tx generator has to avoid such a dependency. Currently tx generator uses `--target-node-id`s only for extracting corresponding IPs/ports from topology file, so now it should receive `--target-node` CLI parameter with not `NodeId`, but with explicit IP/port, for example: `--target-node ("127.0.0.1",3002)`. Co-authored-by: Denis Shevchenko <[email protected]>
deepfire
force-pushed
the
serge/simpler-topology
branch
from
e701a1f to
b1c80b5
Compare
deepfire
force-pushed
the
serge/simpler-topology
branch
from
b1c80b5 to
e701a1f
Compare
|
Handing this over to @Jimbo4350, as per agreement. |
karknu
reviewed
Dec 3, 2019
| @@ -0,0 +1,15 @@ | |||
| { "nodeAddress": | |||
There was a problem hiding this comment.
Why is this needed? I thought that we agreed that local ip address should (optionally) be provided through cli along with port number?
|
Dead. |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 3, 2020
335: Implement real vs mock protocol selection r=Jimbo4350 a=Jimbo4350 Implements the `NodeProtocolMode` type which differentiates whether the node is running a real protocol vs a mock protocol. Changes: - When running a real protocol, the topology comes from a `JSON` file which is decoded to `RealNodeTopology` which specifies the addresses the node intends to connect to. - `socket-dir` command line argument is changed to `socket-path` i.e you must specify socket paths and not dirs anymore. - `NodeId` only needs to be specified for mock protocols (https://github.com/input-output-hk/cardano-node/blob/d24cefd7a4fb1afbf13e8e7f7971e22704673f98/cardano-config/src/Cardano/Config/Protocol.hs#L129) The `cardano-node` client is now as follows (with further help for both `run` and `run-mock` via `cabal exec cardano-node run/run-mock -- --help`): ``` Usage: cardano-node (run | run-mock) [--help] Start node of the Cardano blockchain. Available options: --help Show this help text Execute node with a real protocol. run Execute node with a real protocol. Execute node with a mock protocol. run-mock Execute node with a mock protocol. ``` Relevant: #297, #318, #314 Co-authored-by: Jordan Millar <[email protected]>
|
Closing this PR as this issue is being addressed in #335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/NetworkTopology/NodeSetup/NetworkTopologyandTopologyInfotypes.TODO