-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query for stakepools in run tx build #3176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350 and
nc6
as code owners
September 7, 2021 12:58
newhoggy
commented
Sep 7, 2021
newhoggy
force-pushed
the
update-build-cmd-to-check-tx-inputs
branch
from
September 7, 2021 13:54
8efb8df
to
2d4e43b
Compare
newhoggy
force-pushed
the
update-build-cmd-to-check-tx-inputs
branch
from
September 7, 2021 14:31
2d4e43b
to
1e1e3b3
Compare
newhoggy
changed the title
Update build cmd to check tx inputs
Query for stakepools in run tx build
Sep 7, 2021
Jimbo4350
reviewed
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve once QA gives the 👍
Jimbo4350
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bors merge |
Build succeeded: |
karknu
pushed a commit
that referenced
this pull request
Sep 8, 2021
with changes in ouroboros-network api. Changes includes: - new format for topology files - new configuration options: * RespondersIdleTimeout * ProtocolIdleTimeout * WaitTimeTimeout * TargetNumberOfRootPeers * TargetNumberOfKnownPeers * TargetNumberOfEstablishedPeers * TargetNumberOfActivePeers - new tracers * LocalRootPeers * PeerSelection * DebugPeerSelection * PeerSelectionActons * ConnectionManager * InboundGovernor (Armando) * PeerSelectionCounters (Armando) - old tracers where removed ConnectionManager tracer * it was turned off if ekg direct was defined * renamed "numberConns" from ConnectionManagerCounters to "prunableConns" (in ekg) - leave a thunk in the Mark snapshot - cardano-node using p2p-governor and connection manager Inbound Governor Tracers * Added new constructors * Removed ekg established counter - connection-manager: dump state on SIGUSR1 - Fixed trace severity (#3176) - update ouroboros-network
karknu
pushed a commit
that referenced
this pull request
Oct 18, 2021
with changes in ouroboros-network api. Changes includes: - new format for topology files - new configuration options: * RespondersIdleTimeout * ProtocolIdleTimeout * WaitTimeTimeout * TargetNumberOfRootPeers * TargetNumberOfKnownPeers * TargetNumberOfEstablishedPeers * TargetNumberOfActivePeers - new tracers * LocalRootPeers * PeerSelection * DebugPeerSelection * PeerSelectionActons * ConnectionManager * InboundGovernor (Armando) * PeerSelectionCounters (Armando) - old tracers where removed ConnectionManager tracer * it was turned off if ekg direct was defined * renamed "numberConns" from ConnectionManagerCounters to "prunableConns" (in ekg) - leave a thunk in the Mark snapshot - cardano-node using p2p-governor and connection manager Inbound Governor Tracers * Added new constructors * Removed ekg established counter - connection-manager: dump state on SIGUSR1 - Fixed trace severity (#3176) - update ouroboros-network
karknu
pushed a commit
that referenced
this pull request
Oct 27, 2021
with changes in ouroboros-network api. Changes includes: - new format for topology files - new configuration options: * RespondersIdleTimeout * ProtocolIdleTimeout * WaitTimeTimeout * TargetNumberOfRootPeers * TargetNumberOfKnownPeers * TargetNumberOfEstablishedPeers * TargetNumberOfActivePeers - new tracers * LocalRootPeers * PeerSelection * DebugPeerSelection * PeerSelectionActons * ConnectionManager * InboundGovernor (Armando) * PeerSelectionCounters (Armando) - old tracers where removed ConnectionManager tracer * it was turned off if ekg direct was defined * renamed "numberConns" from ConnectionManagerCounters to "prunableConns" (in ekg) - leave a thunk in the Mark snapshot - cardano-node using p2p-governor and connection manager Inbound Governor Tracers * Added new constructors * Removed ekg established counter - connection-manager: dump state on SIGUSR1 - Fixed trace severity (#3176) - update ouroboros-network
karknu
pushed a commit
that referenced
this pull request
Oct 27, 2021
with changes in ouroboros-network api. Changes includes: - new format for topology files - new configuration options: * RespondersIdleTimeout * ProtocolIdleTimeout * WaitTimeTimeout * TargetNumberOfRootPeers * TargetNumberOfKnownPeers * TargetNumberOfEstablishedPeers * TargetNumberOfActivePeers - new tracers * LocalRootPeers * PeerSelection * DebugPeerSelection * PeerSelectionActons * ConnectionManager * InboundGovernor (Armando) * PeerSelectionCounters (Armando) - old tracers where removed ConnectionManager tracer * it was turned off if ekg direct was defined * renamed "numberConns" from ConnectionManagerCounters to "prunableConns" (in ekg) - leave a thunk in the Mark snapshot - cardano-node using p2p-governor and connection manager Inbound Governor Tracers * Added new constructors * Removed ekg established counter - connection-manager: dump state on SIGUSR1 - Fixed trace severity (#3176) - update ouroboros-network
karknu
pushed a commit
that referenced
this pull request
Nov 1, 2021
with changes in ouroboros-network api. Changes includes: - new format for topology files - new configuration options: * RespondersIdleTimeout * ProtocolIdleTimeout * WaitTimeTimeout * TargetNumberOfRootPeers * TargetNumberOfKnownPeers * TargetNumberOfEstablishedPeers * TargetNumberOfActivePeers - new tracers * LocalRootPeers * PeerSelection * DebugPeerSelection * PeerSelectionActons * ConnectionManager * InboundGovernor (Armando) * PeerSelectionCounters (Armando) - old tracers where removed ConnectionManager tracer * it was turned off if ekg direct was defined * renamed "numberConns" from ConnectionManagerCounters to "prunableConns" (in ekg) - leave a thunk in the Mark snapshot - cardano-node using p2p-governor and connection manager Inbound Governor Tracers * Added new constructors * Removed ekg established counter - connection-manager: dump state on SIGUSR1 - Fixed trace severity (#3176) - update ouroboros-network
This was referenced Nov 9, 2021
[BUG] -
transaction build
does not balance correctly when the certificate is already submitted
#3040
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeTransactionBodyAutoBalance
.query stake-pools
command.This is a second attempt for #3152