Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utxoCostPerWord in the ProtocolParameters needs to be renamed to utxoCostPerByte #4052

Closed
Jimbo4350 opened this issue Jun 14, 2022 · 7 comments · Fixed by #4141
Closed

utxoCostPerWord in the ProtocolParameters needs to be renamed to utxoCostPerByte #4052

Jimbo4350 opened this issue Jun 14, 2022 · 7 comments · Fixed by #4141
Labels
comp: cardano-api era: babbage in-scope This item is being worked and will be part of an upcoming release priority: critical Requires immediate attention. Critical issue that needs to be fixed ASAP and released as hotfix. priority highest issues to be worked on immediately tag: 1.35.0 type: internal feature Non user-facing functionality user type: internal Created by an IOG employee Vasil

Comments

@Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350
Copy link
Contributor Author

In the Babbage era

@JaredCorduan
Copy link
Contributor

for context, in case it's helpful: cardano-foundation/CIPs#265

@CarlosLopezDeLara CarlosLopezDeLara added priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn 1.35.1 Include in 1.35.1 labels Jun 30, 2022
@gitmachtl
Copy link
Contributor

@JaredCorduan can the current tags/1.35.0 handle the change to utxoCostPerByte? will utxoCostPerWord go away with the change or will it stay for a while in parallel?

@JaredCorduan
Copy link
Contributor

@gitmachtl the semantic change in the protocol is attached to the Babbage era, and will go into effect at the moment of the hardfork.

The cardano-api, however, is still translating the new Babbage parameter coinsPerUTxOByte into a "per word" value:

https://github.com/input-output-hk/cardano-node/blob/42809ad3d420f0695eb147d4c66b90573d27cafd/cardano-api/src/Cardano/Api/ProtocolParameters.hs#L1743

In other words, 1.35 is ready to move to the new min-utxo calculation when the hardfork happens, but the CLI will still convert the protocol parameter to be measuring words (not bytes), even though the new calculation will be used. This issue is to not make this conversion.

@gitmachtl
Copy link
Contributor

ah ok thx, this explains why the miniprotocol is sending the CostPerByte value, thx!

@CarlosLopezDeLara CarlosLopezDeLara added priority highest issues to be worked on immediately and removed priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn labels Jul 5, 2022
@lehins
Copy link
Contributor

lehins commented Jul 6, 2022

If I understand correctly this renaming also needs to be applied to ProtocolParametersUpdate:

https://github.com/input-output-hk/cardano-node/blob/0cd6878769a10097e7c780e15efb9919fb94f669/cardano-api/src/Cardano/Api/ProtocolParameters.hs#L1304-L1305

@gitmachtl
Copy link
Contributor

And the removal of the *8 😄

iohk-bors bot added a commit that referenced this issue Jul 8, 2022
4141: Add utxoCostPerByte protocol parameter r=newhoggy a=newhoggy

Resolves #4052
See cardano-foundation/CIPs#265

Co-authored-by: John Ky <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in 9c217ae Jul 8, 2022
@CarlosLopezDeLara CarlosLopezDeLara added 1.35.2 and removed 1.35.1 Include in 1.35.1 labels Jul 8, 2022
@CarlosLopezDeLara CarlosLopezDeLara added in-scope This item is being worked and will be part of an upcoming release and removed 1.35.2 labels Jul 22, 2022
@dorin100 dorin100 added type: internal feature Non user-facing functionality user type: internal Created by an IOG employee comp: cardano-api era: babbage tag: 1.35.0 priority: critical Requires immediate attention. Critical issue that needs to be fixed ASAP and released as hotfix. labels Oct 21, 2022
newhoggy added a commit to IntersectMBO/cardano-api that referenced this issue May 23, 2023
newhoggy added a commit to IntersectMBO/cardano-cli that referenced this issue May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: cardano-api era: babbage in-scope This item is being worked and will be part of an upcoming release priority: critical Requires immediate attention. Critical issue that needs to be fixed ASAP and released as hotfix. priority highest issues to be worked on immediately tag: 1.35.0 type: internal feature Non user-facing functionality user type: internal Created by an IOG employee Vasil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants