-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Multi-signature scheme #638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
081555c
to
0815395
Compare
- MultiSignatureScript typeclass - simple native script multi-sig implementation
- move transaction definitions from `UTxO` to own module - add hashScript to `MultiSignatureScript` typeclass - define first tag for native multi-signature - move address defintions to `Address module`
- also fix use of `stPools` / `stkeys` which was used in reverse
0815395
to
0815915
Compare
0815a13
to
0815a1b
Compare
kevinhammond
pushed a commit
that referenced
this pull request
Oct 28, 2019
…signature Simple Multi-signature scheme
nc6
pushed a commit
that referenced
this pull request
May 19, 2020
638: Add CompactRedeemVerificationKey r=intricate a=intricate Related to #618. This implementation of `RedeemVerificationKey` reduces the memory usage of loading the mainnet `Genesis.Config` from around ~45MB to ~15MB: ![visualization_compactredeemverificationkey](https://user-images.githubusercontent.com/19835357/65299071-f9158000-db3b-11e9-9312-52f56965c953.png) Co-authored-by: Luke Nadur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thiswill introduce a first version of native scripts multi-sig, the main intention is to introduce the necessary types into the executable model and to get a foundation for the definition of the low-level multi-sig format.