Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small edits from 20190503 review #451

Merged
merged 1 commit into from
May 7, 2019
Merged

small edits from 20190503 review #451

merged 1 commit into from
May 7, 2019

Conversation

JaredCorduan
Copy link
Contributor

This PR contains several small edits that came up during the big review on May 3, 2019, as explained in #444. (Note that the figure numbers in that issue are all currently off by one, though the names are correct.)

There are two deviations from issue #444:

  • I don't think that "prev hash" is actually a better name for the hash in the chain transition state, but is better left described as "last header hash". The value in the state holds the hash of the last block which was validated. When a new block comes in for validation, we check "previous hash" in the new block against this value we hold in state. yea?
  • The issue described as "In Figure 55: BHeader rules, s_0 should be c_0." is more subtle than I thought. I made a separate issue for it: operational certificate start #450

@JaredCorduan JaredCorduan requested review from uroboros, mgudemann and nc6 May 6, 2019 19:24
@JaredCorduan JaredCorduan merged commit e7a69d9 into master May 7, 2019
@JaredCorduan JaredCorduan deleted the specs/shelley/small-edits-20190503 branch May 7, 2019 11:51
kevinhammond pushed a commit that referenced this pull request Oct 28, 2019
@JaredCorduan
Merge pull request #451 from input-output-hk/specs/shelley/small-edit…
e492dd7 
…s-20190503

small edits from 20190503 review
nc6 pushed a commit that referenced this pull request May 19, 2020
@iohk-bors @ruhatch
Merge #451
75d4ac1 
451: Implement hedgehog state machine models for SDELEG, UTXOW, and CHAIN systems r=ruhatch a=ruhatch

This is an initial PR to show a proof-of-concept implementation of the state machine testing of various state transition systems. In the end we would like to add tests for DELEG and various parts of the update system, as well as improving test coverage by including invalid chains in the generation.

Co-authored-by: Ru Horlick <[email protected]>
Co-authored-by: Rupert Horlick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc6 nc6 nc6 approved these changes

@uroboros uroboros Awaiting requested review from uroboros

@mgudemann mgudemann Awaiting requested review from mgudemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredCorduan @nc6