Update release tag pattern #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/update-release-tag-pattern
branch
2 times, most recently
from
1044cea to
cdc1ec3
Compare
so the sorting of releases happens in a deterministic/more understandable way.
teodanciu
force-pushed
the
td/update-release-tag-pattern
branch
from
cdc1ec3 to
0dda3a2
Compare
teodanciu
commented
Jan 17, 2023
teodanciu
force-pushed
the
td/update-release-tag-pattern
branch
from
0dda3a2 to
e11f33a
Compare
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that releases get sorted in a deterministic way.
Description
Without this change, if we realease:
cardano-ledger-spec-1.0.0cardano-ledger-spec-2.0.0....
cardano-ledger-spec-10.0.0then the latter won't be considered the latest, because the sorting is done alphabetically.
If we use
cardano-ledger-spec-YYYY-MM-DDtag as proposed in this PR and tag based on the current date, then the provided alphabetical sorting should give us the desired sorting by latest.Checklist
fourmolu(which can be run withscripts/fourmolize.sh