Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babbage: Translation #2633

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Babbage: Translation #2633

merged 2 commits into from
Jan 27, 2022

Conversation

goolord
Copy link
Contributor

@goolord goolord commented Jan 25, 2022

resolves #2470

-- Auxiliary instances and functions
--------------------------------------------------------------------------------

translateViaCBORAnn :: (ToCBOR a, FromCBOR (Annotator b)) => Text -> a -> Except DecoderError b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to think of a good place for this function to live so that we don't have to copy it every era. Maybe in Cardano.Ledger.Serialization from the cardano-ledger-core package?

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be great as soon as CI is happy, thanks!

@JaredCorduan JaredCorduan merged commit 5fde6c0 into master Jan 27, 2022
@iohk-bors iohk-bors bot deleted the zc/babbage-translate branch January 27, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alonzo to Babbage translation
2 participants