CI attempt 2 #156
CI attempt 2 #156
Conversation
|
Okay, this basically works, we just can't actually build |
|
Can we add a revision to c-c-c to turn off Werror? |
|
I'm going to - I got diverted into writing a script to add revisions... |
michaelpj
force-pushed
the
mpj/builder2
branch
3 times, most recently
from
5fc222c to
ba7f62f
Compare
|
Okay, I think this is good to go. I would appreciate a review from @andreabedini if he's got time. It will need me to change the name of the required check before we can merge, though. Maybe also @shlevy might be interested to see how we're using nixbuild.net in the end. |
|
In a later PR we can work on getting the other packages to work. Also, a notable restriction I had to make: I was going to build all the versions of the smoke-test packages, but we can't do that because some of them are going to be irredeemably unbuildable with old/new GHCs. I don't know what to do about that. I've compromised on just building the latest versions of things. |
flake.nix
Outdated
| let | ||
| # The latest version in the set (attrValues sorts by key). Remove the 'recurseForDerivations' here otherwise | ||
| # we get that! | ||
| latest = versionToValue: lib.last (lib.attrValues (builtins.removeAttrs versionToValue ["recurseForDerivations"])); | ||
| compilerPkgs = builtins.getAttr compiler haskellPackages; | ||
| smokeTestPkgs = lib.recurseIntoAttrs (lib.genAttrs smokeTestPackages (pkgname: latest (builtins.getAttr pkgname compilerPkgs))); | ||
| in smokeTestPkgs); |
There was a problem hiding this comment.
I feel this logic should belong elsewhere. I think it's here because I hid the logic of getting the list of chap package inside ./builder.
I think we should decouple wrangling the CHaP metadata and defining the test jobs.
I think we can make ./builder do only the chap-package-components part:
{ pkgs, CHaP }:
compiler-nix-name: package-name: package-version:
...
Then we move out the part manipulates package.json elsewhere (still in flake.nix? in ./chap.nix? ./builder/chap.nix?)
CHaP:
rec {
# { "foo" : [ "X.Y.Z" "P.Q.R" ], ... }
chap-package-attrs = ...,
# { "foo": "X.Y.Z" }
chap-package-last versions = ...
}
Then in flake.nix we can just apply the builder to these two attrset.
There was a problem hiding this comment.
Sounds good to me.
There was a problem hiding this comment.
Okay, I did a big refactor, I think this is a lot nicer.
|
Not overboard at all, I like comments :) |
|
I'm going to merge so we can iterate from here. |
No description provided.