HF integration #1112
Merged
HF integration #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
force-pushed
the
kderme/hf-integration
branch
4 times, most recently
from
dc33deb to
9c5c1ad
Compare
kderme
force-pushed
the
kderme/hf-integration
branch
2 times, most recently
from
e8077b7 to
77d5626
Compare
kderme
force-pushed
the
kderme/hf-integration
branch
2 times, most recently
from
1f0a861 to
05088fc
Compare
This was referenced May 24, 2022
Closed
kderme
force-pushed
the
kderme/hf-integration
branch
2 times, most recently
from
bd15a2d to
ce97d18
Compare
Merged
| import Cardano.Mock.Forging.Tx.Alonzo.ScriptsExamples | ||
| import Cardano.Mock.Forging.Tx.Generic | ||
| import Cardano.Mock.Forging.Types | ||
| -- import qualified Data.Maybe as Strict |
There was a problem hiding this comment.
Suggested change
| -- import qualified Data.Maybe as Strict |
| {-# LANGUAGE TupleSections #-} | ||
| {-# LANGUAGE TypeApplications #-} | ||
|
|
||
| {-# OPTIONS_GHC -Wno-orphans #-} |
There was a problem hiding this comment.
Suggested change
| {-# OPTIONS_GHC -Wno-orphans #-} |
Seems to compile without this option.
| , _poolRAcnt = RewardAcnt Testnet rwCred | ||
| , _poolOwners = Set.fromList owners | ||
| , _poolRelays = StrictSeq.singleton $ SingleHostAddr Strict.SNothing Strict.SNothing Strict.SNothing | ||
| , _poolMD = Strict.SJust $ PoolMetadata (fromJust $ textToUrl "best.pool") "89237365492387654983275634298756" |
There was a problem hiding this comment.
A comment saying where these values come from and whether they are special in some way, would be helpful.
| import Cardano.Mock.Forging.Tx.Generic | ||
| import Cardano.Mock.Forging.Types | ||
|
|
||
| delegateAndSendBlocks :: Int -> Interpreter -> IO [CardanoBlock] |
There was a problem hiding this comment.
A comment describing what this is doing and why would be useful.
|
|
||
| {-# OPTIONS_GHC -Wno-orphans #-} | ||
|
|
||
| module Cardano.Mock.Forging.Tx.Babbage where |
There was a problem hiding this comment.
I'd prefer a nice export list here with some comments but I see that isn't the case for other Eras.
| stats <- liftIO $ textShowStats cache | ||
| liftIO . logInfo tracer $ stats | ||
| liftIO . logInfo tracer $ "Starting epoch " <> textShow (unEpochNo en) | ||
| LedgerStartAtEpoch en -> | ||
| -- This is different from the previous case in that the db-sync started | ||
| -- in this epoch, for example after a restart, instead of after an epoch boundary. | ||
| liftIO . logInfo tracer $ "Starting at epoch " <> textShow (unEpochNo en) | ||
| LedgerDeltaRewards rwd -> do | ||
| LedgerDeltaRewards _e rwd -> do |
There was a problem hiding this comment.
Suggested change
| LedgerDeltaRewards _e rwd -> do | |
| LedgerDeltaRewards _ rwd -> do |
| blockHash = | ||
| Crypto.hashToBytes . Protocol.unHashHeader | ||
| Crypto.hashToBytes -- . Protocol.unHashHeader |
There was a problem hiding this comment.
Suggested change
| Crypto.hashToBytes -- . Protocol.unHashHeader | |
| Crypto.hashToBytes |
| @@ -49,8 +49,9 @@ ledgerAddrBalance addr lsc = | |||
| LedgerStateAllegra st -> getShelleyBalance addr $ getUTxO st | |||
| LedgerStateMary st -> getShelleyBalance addr $ getUTxO st | |||
| LedgerStateAlonzo st -> getAlonzoBalance addr $ getUTxO st | |||
| LedgerStateBabbage _st -> panic "undefined Babbage ledgerAddrBalance" | |||
There was a problem hiding this comment.
This should be using the existing Either Text Word64 for signalling an un-expected return.
The calling code in Cardano.DbTool.Validate.Ledger logs the result on Left.
Suggested change
| LedgerStateBabbage _st -> panic "undefined Babbage ledgerAddrBalance" | |
| LedgerStateBabbage _st -> Left "undefined Babbage ledgerAddrBalance" |
| pure (eutxo, maTxOuts) | ||
| where | ||
| hasScript :: Bool | ||
| hasScript = maybe False Generic.hasCredScript (Generic.getPaymentCred addr) | ||
|
|
||
| inertCollateralTxOut |
There was a problem hiding this comment.
Suggested change
| inertCollateralTxOut | |
| insertCollateralTxOut |
| Left (_err, bs) -> insertStakeAddress txId rewardAddr (Just bs) | ||
| Right addrId -> pure addrId | ||
|
|
||
| -- If the address already esists in the table, it will not be inserted again (due to |
There was a problem hiding this comment.
Suggested change
| -- If the address already esists in the table, it will not be inserted again (due to | |
| -- If the address already exists in the table, it will not be inserted again (due to |
kderme
force-pushed
the
kderme/hf-integration
branch
2 times, most recently
from
9e20208 to
5613022
Compare
This also improves performance
This avoids many transformations from ledger types, but more importantly ledger types are backed by ShortByteString which is not pinned memory and doesn't cause heap fragmentation.
Using the whole CostModel caused errors because the unique key can't be that big.
Rollbacks are extremely slow without them
erikd
force-pushed
the
kderme/hf-integration
branch
from
5613022 to
9f24209
Compare
erikd
force-pushed
the
kderme/hf-integration
branch
from
9f24209 to
10868e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1081 and #1120