Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CIP 14 assets fingerprints mapping #868

Closed
SmaugPool opened this issue Oct 4, 2021 · 0 comments
Closed

Add support for CIP 14 assets fingerprints mapping #868

SmaugPool opened this issue Oct 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@SmaugPool
Copy link

SmaugPool commented Oct 4, 2021 •
edited
Loading

CIP 14 asset fingerprints are great for interoperability between wallets, NFT viewers/websites and marketplaces, but as they are not bijective, they require a mapping to lookup an asset from its fingerprint.

It would be great to have this mapping provided by cardano-db-sync.

An Haskell reference implementation is provided in the CIP:
https://cips.cardano.org/cips/cip14/#referenceimplementation

As well as test vectors:
https://cips.cardano.org/cips/cip14/#testvectors

To save space and guarantee consistency, it might also be a good opportunity to add an asset table with the policy id, asset name & fingerprint and reference it from ma_tx_mint and ma_tx_out tables.
@SmaugPool SmaugPool added the bug Something isn't working label Oct 4, 2021
@erikd erikd added enhancement New feature or request and removed bug Something isn't working labels Oct 5, 2021
erikd added a commit that referenced this issue Oct 7, 2021
@erikd
db: Update the schema wrt to multi-assets
def3db8 
* Add a new table `multi_asset` which includes the asset fingerprint.
* Add a reference from `ma_tx_mint` and `ma_tx_out` to `multi_asset`.
* Drop the `policy` and `name` fields of `ma_tx_mint` and `ma_tx_out`.

Closes: #868
erikd added a commit that referenced this issue Oct 7, 2021
@erikd
db: Update the schema wrt to multi-assets
73dff7a 
* Add a new table `multi_asset` which includes the asset fingerprint.
* Add a reference from `ma_tx_mint` and `ma_tx_out` to `multi_asset`.
* Drop the `policy` and `name` fields of `ma_tx_mint` and `ma_tx_out`.

Closes: #868
erikd added a commit that referenced this issue Oct 7, 2021
@erikd
db: Update the schema wrt to multi-assets
56f9e07 
* Add a new table `multi_asset` which includes the asset fingerprint.
* Add a reference from `ma_tx_mint` and `ma_tx_out` to `multi_asset`.
* Drop the `policy` and `name` fields of `ma_tx_mint` and `ma_tx_out`.

Closes: #868
@erikd erikd closed this as completed in 97fb1c4 Oct 8, 2021
erikd added a commit that referenced this issue Oct 8, 2021
@erikd
db: Update the schema wrt to multi-assets
b3d8bf9 
* Add a new table `multi_asset` which includes the asset fingerprint.
* Add a reference from `ma_tx_mint` and `ma_tx_out` to `multi_asset`.
* Drop the `policy` and `name` fields of `ma_tx_mint` and `ma_tx_out`.

Cherry pick of 97fb1c4 from master.

Closes: #868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikd @SmaugPool