Clarify documentation and properties of splitCoin.
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
reviewed
Apr 6, 2020
paweljakubas
approved these changes
Apr 6, 2020
paweljakubas
reviewed
Apr 6, 2020
jonathanknowles
commented
Apr 6, 2020
jonathanknowles
commented
Apr 6, 2020
jonathanknowles
commented
Apr 6, 2020
Justification: this name is consistent with the description of the function.
Additionally, add associated Arbitrary instance and coverage check.
jonathanknowles
force-pushed
the
jonathanknowles/split-coin
branch
from
fd092af to
6f5bd77
Compare
Additionally, test that shrinking always generates valid data.
When it's not possible to divide a coin evenly, each integral coin value in the resulting list should always be within unity of the ideal unrounded result. This change adds a test to verify this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#18
#21
#22
Summary
This PR:
splitCoin, adding examples.splitCoinpreserves the total sum.splitCoinonly produces valid coins.