Add property to verify that fee distributions are optimal. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `distributeFee` function is restricted to generating integer fee distributions, there will be some deviation from the ideal unrounded fee distribution, caused by rounding. This property verifies that the absolute deviation from the ideal unrounded fee distribution is minimal across all possible ways to round.
jonathanknowles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Preparation for #21.
Summary
This PR adds a simple property to verify that the fee distribution produced by
distributeFeeis optimal.Since
distributeFeeis restricted to generating integer fee distributions, for any given distribution there will be some deviation from the ideal unrounded fee distribution, caused by the particular choice of rounding.This property verifies that the absolute deviation from the ideal unrounded fee distribution is minimal across all possible ways to round.