-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API to 10.4.0.0 #988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
smelc
force-pushed
the
smelc/update-api-to-10.4.0.0
branch
from
December 6, 2024 09:17
d406e3e
to
5768460
Compare
smelc
requested review from
a team,
Jimbo4350,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
December 6, 2024 09:20
2 tasks
smelc
commented
Dec 6, 2024
@@ -29,3 +33,9 @@ instance ToJSON HashableScriptData where | |||
[ "hash" .= hashScriptDataBytes hsd | |||
, "json" .= scriptDataToJsonDetailedSchema hsd | |||
] | |||
|
|||
-- TODO Delete me when added in API | |||
instance Convert Exp.Era MaryEraOnwards where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will get removed when we merge this PR: IntersectMBO/cardano-api#701 and update CLI afterwards.
Follow-up PR is here: #989
This was referenced Dec 6, 2024
palas
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Checklist