Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API to 10.4.0.0 #988

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Update API to 10.4.0.0 #988

merged 5 commits into from
Dec 10, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Dec 6, 2024

Changelog

- description: |
    Update API to 10.4.0.0
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc mentioned this pull request Dec 6, 2024
3 tasks
@@ -29,3 +33,9 @@ instance ToJSON HashableScriptData where
[ "hash" .= hashScriptDataBytes hsd
, "json" .= scriptDataToJsonDetailedSchema hsd
]

-- TODO Delete me when added in API
instance Convert Exp.Era MaryEraOnwards where
Copy link
Contributor Author

@smelc smelc Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get removed when we merge this PR: IntersectMBO/cardano-api#701 and update CLI afterwards.

Follow-up PR is here: #989

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@smelc smelc added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 740bcc3 Dec 10, 2024
26 checks passed
@smelc smelc deleted the smelc/update-api-to-10.4.0.0 branch December 10, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants