Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new types to list of accepted types and remove deprecated ones #892

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add new types to list of accepted types and remove deprecated ones #892

merged 1 commit into from
Oct 17, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Sep 11, 2024 •
edited
Loading

Changelog

- description: |
    Added support for the new envelope types for transactions: "TxSignedShelley", "Tx AllegraEra", "Tx MaryEra", "Tx AlonzoEra", "Tx BabbageEra", "Tx ConwayEra".
    The following old envelope types are no longer supported: "Witnessed Tx ShelleyEra", "Witnessed Tx AllegraEra", "Witnessed Tx MaryEra", "Witnessed Tx AlonzoEra", "Witnessed Tx BabbageEra", "Witnessed Tx ConwayEra", "Unwitnessed Tx ByronEra", "Unwitnessed Tx ShelleyEra", "Unwitnessed Tx AllegraEra", "Unwitnessed Tx MaryEra", "Unwitnessed Tx AlonzoEra", "Unwitnessed Tx BabbageEra", "Unwitnessed Tx ConwayEra"
  type:
  - bugfix
  - breaking

Context

There was an issue with transactions created using the non-deprecated function serialiseToTextEnvelope as alternative to serialiseTxLedgerCddl. Because the implementation in cardano-cli still doesn't accept it.

This PR ensures the new types are accepted.

There is a corresponding PR that does a change required by this PR in cardano-api: IntersectMBO/cardano-api#634

How to trust this PR

Ensure this solves the problem that was reported.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the bug Something isn't working label Sep 11, 2024
@palas palas self-assigned this Sep 11, 2024
@palas palas mentioned this pull request Sep 11, 2024
Merged
3 tasks
@palas palas requested a review from ch1bo September 11, 2024 23:00
@palas palas force-pushed the fix-new-type-issues branch from 8e63873 to ee43259 Compare September 19, 2024 20:00
ch1bo
ch1bo reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the new supported list of envelope types in --tx-file arguments? The code does not list it explicitly any more and as a user I would want to read about the concrete changes in a changelog or so.

@palas palas force-pushed the fix-new-type-issues branch from 1f0137b to 69979f3 Compare October 17, 2024 09:43
@palas palas requested review from ch1bo and carbolymer October 17, 2024 10:06
@palas palas changed the title Add new types to list of accepted types Add new types to list of accepted types and remove deprecated Oct 17, 2024
@palas palas changed the title Add new types to list of accepted types and remove deprecated Add new types to list of accepted types and remove deprecated ones Oct 17, 2024
Jimbo4350
Jimbo4350 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please squash the commits.

@palas palas force-pushed the fix-new-type-issues branch from 85b7488 to e2466e9 Compare October 17, 2024 13:17
@palas
Add new types to list of accepted types, remove deprecated, and refactor
9af9596 
* Add new types to list of accepted types
* Refactor `readCddlTx` and `readCddlWitness` for testability
* Remove deprecated envelope types
* Generate `TextEnvelope` types from era names
* Generate `TextEnvelope` types using `textEnvelopeType` directly
@palas palas force-pushed the fix-new-type-issues branch from e2466e9 to 9af9596 Compare October 17, 2024 13:18
@palas palas added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 235cb3e Oct 17, 2024
25 checks passed
@palas palas deleted the fix-new-type-issues branch October 17, 2024 14:43
@gitmachtl
Copy link
Contributor

@Jimbo4350 what exactly is new in Added support for the new envelope types for transactions: "TxSignedShelley", "Tx AllegraEra", "Tx MaryEra", "Tx AlonzoEra", "Tx BabbageEra", "Tx ConwayEra". ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@smelc smelc Awaiting requested review from smelc

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

@ch1bo ch1bo Awaiting requested review from ch1bo

@carbolymer carbolymer Awaiting requested review from carbolymer

Assignees

@palas palas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@palas @gitmachtl @carbolymer @ch1bo @Jimbo4350