Add support for fetching tip through cardano-ping #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
Jimbo4350
force-pushed
the
jordan/bump-cardano-ping-0.4
branch
2 times, most recently
from
109e6c7 to
0ac5661
Compare
Added NodeToClientVersionV17 Update cardano-ping to version 0.4.0.2 in order to support fetching tip.
Jimbo4350
force-pushed
the
jordan/bump-cardano-ping-0.4
branch
from
0ac5661 to
9d71274
Compare
carbolymer
reviewed
Sep 9, 2024
| mconcat | ||
| [ Opt.long "tip" | ||
| , Opt.short 't' | ||
| , Opt.help "Request tip then exit." |
There was a problem hiding this comment.
A short explanation what the tip is would be nice.
carbolymer
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist