Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove era|legacy transaction view #868

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Aug 21, 2024

Changelog

- description: |
    Remove `era transaction view` and `transaction view` commands. Use `debug transaction view` instead.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

  • It only removes code

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/remove-non-debug-transaction-view branch 2 times, most recently from 847147a to c02ce27 Compare August 22, 2024 08:01
@smelc smelc marked this pull request as ready for review August 22, 2024 08:01
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm wondering if it's not too soon.

@smelc
Copy link
Contributor Author

smelc commented Aug 22, 2024

I'm wondering if it's not too soon.

@Jimbo4350> what do you think?

This can clearly wait a bit more if you feel like it. It's just I like my issues' list to shrink 😄

@smelc smelc force-pushed the smelc/remove-non-debug-transaction-view branch from c02ce27 to 77ec0bc Compare September 24, 2024 14:40
@smelc smelc enabled auto-merge September 24, 2024 14:42
@smelc smelc force-pushed the smelc/remove-non-debug-transaction-view branch from 77ec0bc to 93c194b Compare September 24, 2024 14:56
@smelc smelc added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 61dcd88 Sep 24, 2024
25 checks passed
@smelc smelc deleted the smelc/remove-non-debug-transaction-view branch September 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate [era] transaction view
2 participants