Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol params order for minFeeA and minFeeB #693

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ArturWieczorek
Copy link
Contributor

Changelog

- description: |
    Fix protocol params order for minFeeA and minFeeB
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #692

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer
Copy link
Contributor

Nice catch, thanks!

@carbolymer carbolymer merged commit fbe3325 into main Apr 4, 2024
16 of 19 checks passed
@carbolymer carbolymer deleted the artur/fix-protocol-params-order branch April 4, 2024 17:11
@carbolymer
Copy link
Contributor

Force merging since this simple change passed GHA, looks correct and Hydra is broken again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minFeeA swapped with minFeeB
2 participants