-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an error on identical action-ids in votes of one voter #681
Conversation
Question to reviewers:
|
94b628a
to
e3d3cbd
Compare
Yes. Can be done in a separate PR. |
5f81d19
to
7857ae8
Compare
PR to move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -93,6 +93,7 @@ data TxCmdError | |||
| TxCmdTxUpdateProposalValidationError TxUpdateProposalValidationError | |||
| TxCmdScriptValidityValidationError TxScriptValidityValidationError | |||
| TxCmdProtocolParamsConverstionError ProtocolParametersConversionError | |||
| forall era. TxCmdTxGovDuplicateVotes (TxGovDuplicateVotes era) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could avoid the existential by setting the crypto to StandardCrypto
mapb = L.unVotingProcedures (unVotingProcedures vpsb) | ||
allVoters = Set.union (Map.keysSet mapa) (Map.keysSet mapb) | ||
mergeVotesOfOneVoter acc voter = | ||
Map.union acc <$> case (Map.lookup voter mapa, Map.lookup voter mapb) of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to us differenceWith here.
Changelog
Context
Fixes #662
How to trust this PR
cabal test cardano-cli-test --test-options '-p "/conway transaction build one voter many votes/"'
ExitSuccess
Checklist