Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --drep-script-hash parameter to conway governance drep retirement-certificate #678

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add --drep-script-hash parameter to conway governance drep retirement-certificate #678

merged 1 commit into from
Mar 25, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 25, 2024

Changelog

- description: |
    Add `--drep-script-hash` parameter to `conway governance drep retirement-certificate`
  type:
  - feature        # introduces a new feature

Context

This aims to solve issue #659

How to trust this PR

It is small, but probably check that the changes to the golden tests and the changes to the code make sense too.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Mar 25, 2024
@palas palas self-assigned this Mar 25, 2024
@palas palas force-pushed the drep-retirement-certificate-support-for-script-based-dreps branch from 3a4466c to a2647d1 Compare March 25, 2024 20:46
@palas palas marked this pull request as ready for review March 25, 2024 20:47
@palas palas added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit db1ca11 Mar 25, 2024
18 checks passed
@palas palas deleted the drep-retirement-certificate-support-for-script-based-dreps branch March 25, 2024 21:55
@palas palas mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@carbolymer carbolymer Awaiting requested review from carbolymer

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @smelc