Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cardano-api-8.40.0.0 #648

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Update cardano-api-8.40.0.0 #648

merged 2 commits into from
Mar 14, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 14, 2024

Changelog

- description: |
    Update [cardano-api-8.40.0.0](https://github.com/IntersectMBO/cardano-api/blob/main/cardano-api/CHANGELOG.md#84000)
  type:
  - improvement

Context

This PR updates .cabal file and removes Lovelace in favor of Coin since it was removed in cardano-api-8.40.0.0.

It still relies on a stanza because CHaP hasn't been updated at the time of writing. But it should be removed before merging it.

How to trust this PR

This PR should be a refactoring, it shouldn't have any changes to functionality.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Mar 14, 2024
@palas palas self-assigned this Mar 14, 2024
@carbolymer carbolymer changed the title [DON'T MERGE YET] - Update cardano-api-8.40.0.0 Update cardano-api-8.40.0.0 Mar 14, 2024
@carbolymer carbolymer marked this pull request as ready for review March 14, 2024 09:39
@carbolymer carbolymer enabled auto-merge March 14, 2024 09:50
@carbolymer carbolymer added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit 4ff26c0 Mar 14, 2024
17 checks passed
@carbolymer carbolymer deleted the bump-cardano-api branch March 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palas @carbolymer @smelc