Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cardano-ping #633

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Bump cardano-ping #633

merged 1 commit into from
Mar 6, 2024

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Mar 5, 2024

Changelog

- description: |
    Bump cardano-ping version
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

cardano-cli contains a fix for 8.9.0 release

@bolt12
Copy link
Contributor Author

bolt12 commented Mar 5, 2024

corresponding chap PR: IntersectMBO/cardano-haskell-packages#689

@smelc
Copy link
Contributor

smelc commented Mar 5, 2024

@bolt12> since you updated both CHaP and hackage, you need to update the flake's lock for both too, like this:

nix flake update CHaP
nix flake update haskellNix/hackage

If I'm not mistaken, the change to flake.lock misses the second command

@bolt12
Copy link
Contributor Author

bolt12 commented Mar 5, 2024

I updated CHaP's flake.lock entry. I don't think hackage is necessary but I'll update it

@bolt12 bolt12 force-pushed the bolt12/bump-cardano-ping branch from 7e3cb96 to ddf7b77 Compare March 5, 2024 14:58
@smelc
Copy link
Contributor

smelc commented Mar 5, 2024

@bolt12> I let you merge when you see fit.

@bolt12
Copy link
Contributor Author

bolt12 commented Mar 5, 2024

I am not authorized to merge it, unfortunately. Feel free to do so!

@bolt12 bolt12 requested a review from smelc March 5, 2024 16:42
@smelc smelc added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit f438557 Mar 6, 2024
17 checks passed
@smelc smelc deleted the bolt12/bump-cardano-ping branch March 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants