create-testnet-data: add --drep-keys flag #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
smelc
force-pushed
the
smelc/create-testnet-data-drep-keys-1
branch
from
69e1847 to
b434814
Compare
carlhammann
approved these changes
Jan 12, 2024
| @@ -26,22 +39,16 @@ tree root = do | |||
| subTrees <- mapM tree subs | |||
| return $ files ++ concat subTrees | |||
|
|
|||
| -- | This test tests the non-transient case, i.e. it maximizes the files | |||
| -- that can be written to disk. Execute this test with: | |||
| -- @cabal test cardano-cli-golden --test-options '-p "/golden create testnet data/'@ | |||
There was a problem hiding this comment.
Nice. I always forget how this is done... Maybe we should add this to the CONTRIBUTING.md?
There was a problem hiding this comment.
I agree that we should add it somewhere too. I think this is the best place: https://github.com/input-output-hk/cardano-node-wiki/wiki/Running-tests
We can link from CONTRIBUTING.md to it then.
There was a problem hiding this comment.
I've added PR there: input-output-hk/cardano-node-wiki#37
Jimbo4350
approved these changes
Jan 12, 2024
| @@ -54,6 +54,8 @@ hprop_golden_create_testnet_data = | |||
|
|
|||
| H.diffVsGoldenFile generated'' "test/cardano-cli-golden/files/golden/conway/create-testnet-data.out" | |||
|
|
|||
| -- | This test tests the non-transient case, i.e. it generates strictly | |||
There was a problem hiding this comment.
Did you mean it tests the transient case?
There was a problem hiding this comment.
Indeed, good catch 👍 Fixed 👍
carbolymer
reviewed
Jan 12, 2024
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| module Cardano.CLI.EraBased.Run.Governance.DRep | |||
| ( runGovernanceDRepCmds | |||
| , runGovernanceDRepKeyGenCmd | |||
carbolymer
reviewed
Jan 12, 2024
| runGovernanceDRepKeyGenCmd | ||
| Cmd.GovernanceDRepKeyGenCmdArgs | ||
| { vkeyFile | ||
| , skeyFile | ||
| } = firstExceptT GovernanceCmdWriteFileError $ do | ||
| } = do |
carbolymer
approved these changes
Jan 12, 2024
smelc
force-pushed
the
smelc/create-testnet-data-drep-keys-1
branch
from
b434814 to
d0c54e2
Compare
…the keys. No registration, no delegation.
smelc
force-pushed
the
smelc/create-testnet-data-drep-keys-1
branch
from
d0c54e2 to
1695d07
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
We cannot yet create the registration and the delegation for the dreps, but we'll need to generate keys when we do, and this first step will already help us remove some code in cardano-node here.
How to trust this PR
key-genbackendChecklist