Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify DRep queries with an all-or-some logic #555

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Jan 8, 2024

Changelog

- description: |
    Make queries that optionally filter their result by DRep keys more explicit:
    - `cardano-cli conway query drep-state`
    - `cardano-cli conway query drep-stake-distribution`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This is in the same spirit as #541. I'm targeting the branch of that PR here, to make the diff clearer. When #541 is merged, that'll be the diff to main.

I also deleted a few unused parsers in Cardano.CLI.EraBased.Options.Common.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carlhammann carlhammann force-pushed the ch/clarify-all-or-some-flags-drep branch from 3b8a099 to 4e1eaef Compare January 8, 2024 12:03
@carlhammann carlhammann changed the base branch from main to ch/clarify-all-or-some-flags January 8, 2024 12:07
@carlhammann carlhammann force-pushed the ch/clarify-all-or-some-flags-drep branch from 4e1eaef to b028ac9 Compare January 8, 2024 12:19
@carlhammann carlhammann marked this pull request as ready for review January 8, 2024 12:21
Base automatically changed from ch/clarify-all-or-some-flags to main January 9, 2024 17:53
@carlhammann carlhammann force-pushed the ch/clarify-all-or-some-flags-drep branch from b028ac9 to 76314a8 Compare January 10, 2024 10:44
@carlhammann carlhammann enabled auto-merge January 10, 2024 10:45
@carlhammann carlhammann added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 05c4001 Jan 10, 2024
19 checks passed
@carlhammann carlhammann deleted the ch/clarify-all-or-some-flags-drep branch January 10, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants